Skip to content

Fix broken startup-css-check [RUN AS-IF-FOSS]

Paul Slaughter requested to merge ps-fix-startup-css-check-job into master

What does this MR do?

This MR fixes master:broken where the startup-css-check job was not run for an MR that was merged just shortly after the startup-css-check was introduced to the pipeline.

!62866 (merged)

What caused this img.emoji change?

Originally, @markrian and I were concerned that our fixtures were non-deterministic since there's an experiment being run to add an emoji in that related MR.

BUT! If you look at the generated HTML fixture (for instance startup-general.html) for this, you'll notice that img.emoji actually doesn't show up at all.

What does show up is a <ul ... data-view-model="... emoji:"> now that we've added a new emoji property to top_nav_menu_item.rb. We can conclude two things here:

  • The failure is not flaky or tied to experiments like we were concerned.
  • There's an interesting quirk with how we're currently configuring PurgeCSS. By default, PurgeCSS just looks for words. It is not aware of context of the words. So, PurgeCSS is now finding the word emoji and including CSS referencing it.

There's clearly room for improvement with how we configure Purge, but that's something we can iterate on and does not block fixing the master:broken.

Edited by Paul Slaughter

Merge request reports