Skip to content

Decouple content-wrapper and content-wrapper-margin

Paul Slaughter requested to merge 301143-setup-content-wrapper into master

What does this MR do?

This MR pulls the margin: part of content-wrapper into it's own class, so that it can be reused by the upcoming top nav responsive redesign.

Screenshots (strongly suggested)

What should I be looking for?

  • There are 3 layouts that are effects: terms, application, fullscreen
    • The Terms & Conditions page tests the terms layout
    • The Project page tests the application layout
    • The Web IDE tests the fullscreen layout
  • You'll notice that we actually fix a layout issue in the Web IDE with system footers 🎉
Description Before (on master) After (this MR)
Terms & Conditions page (inspect) before_terms after_terms
Project before_project after_project
Project (with perf bar) before_project_pb after_project_pb
Project (with perf bar + system header) before_project_pb_header after_project_pb_header
Project (all + inspect) before_project_full after_project_full
Web IDE before_ide after_ide
Web IDE (with perf bar) before_ide_pb after_ide_pb
Web IDE (all + inspect) before_ide_full after_ide_full

2021-06-06 smoke test

Project with system head and foot Web IDE
Screen_Shot_2021-06-06_at_11.25.22_AM Screen_Shot_2021-06-06_at_11.26.21_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #301143 (closed)

Edited by Paul Slaughter

Merge request reports

Loading