Skip to content

Hide search icon again on larger breakpoints

What does this MR do?

Fixes a problem where both search icon and search box where visible on larger breakpoints. We can move back to the new gl- classes once gitlab-ui!2246 (closed) is merged and the new gitlab-ui update is being used.

Screenshots (strongly suggested)

Before After
image image

How to test?

You may want to check this out with both the :combined_menu feature flag on and off.

Description Feature.enable(:combined_menu) Feature.disable(:combined_menu)
Large display - No search icon visible 🎉 ff_on_lg ff_off_lg
Medium display - Search icon visible 🎉 ff_on_md ff_off_md
Small display - Search icon not visible with feature flag on 🎉 ff_on_sm ff_off_sm

Does this MR meet the acceptance criteria?

Conformity

Related to #333381 (closed)

Edited by Paul Slaughter

Merge request reports

Loading