Skip to content

Add the ability to deep link into group/project member tabs

📖 What does this MR do?

Related to #327369 (closed)

Uses the GitLab UI feature added in gitlab-ui!2190 (merged) to add support for deep linking into the Group/Project members tabs (Members, Groups, Invited, Access requests). This functionality will be used in a follow up MR to remove some broken controls in the admin area and instead just link directly to the Access requests tab.

💻 Local testing

  1. Create a group or project and navigate to Group or Project -> Group/Project information -> Members

How to add a group to the Groups tab

  1. Click the Invite group tab

How to add an invited member to the Invited tab

  1. In the GitLab member or Email address enter an email that a user does not already own
  2. Click Invite "example@test.com" by email

How to add a user to the Access requests tab

  1. Log in (or impersonate) a user that doesn't already have access to the group or project
  2. Navigate to the group or project overview
  3. Click Request access located below the project/group name

How to test pagination

  1. Change app/controllers/projects/project_members_controller.rb#L31 to:
@project_members = present_members(project_members.non_invite.page(params[:page]).per(2))
  1. Change app/controllers/groups/group_members_controller.rb#L0 to 2

📹 Videos

Pagination changed to 2 per page in videos

View Before After
Group members Screen_Recording_2021-06-18_at_7.58.19_AM_720p Screen_Recording_2021-06-18_at_7.46.51_AM_720p
Project members Screen_Recording_2021-06-18_at_7.53.09_AM_720p Screen_Recording_2021-06-18_at_7.48.17_AM_720p

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading