Remove access request controls in admin area and replace with "Manage access" button
Related to #327369 (closed)
📖 What does this MR do?
In "Admin area" -> "Projects or Groups" -> "Choose project or group" there is a section that lists all the open access requests. This section has controls to change the expiration date, role and accept/deny the access request. These controls are currently broken and have been for a long time (at least a year as far as I can tell). My guess is these controls were accidentally broken when refactoring to page specific JavaScript at some point.
In #327369 (closed) it was decided it would make the most sense to remove these controls and instead add a "Manage access" button that deep links into the "Access requests" tab on the project/group members page. Removing these controls will also allow us to delete a decent amount of legacy HAML and jQuery (will be taken care of in a follow-up MR).
💻 Local testing
- Login as an Admin
- Create a public group or project and leave that open in a tab
- In a new tab click "Menu" -> "Admin" in the top nav
- Navigate to "Overview" -> "Users" and choose a user
- Click "Impersonate" in the upper right corner
- Refresh the other tab with the group or project and click "Request access" under the project/group name
- Click the "Stop impersonation" button in the upper right corner
- Navigate to "Admin" -> "Groups or Projects" -> the project you created
📷 Screenshots
| View | Before | After |
|---|---|---|
| Project |  |
 |
| Group |  |
 |
🚦 Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team