Skip to content

Show invalid checkbox state in Activation Modal

Angelo Gulina requested to merge 334863-modal-checkbox into master

What does this MR do?

This MR makes sure the correct UI state is displayed for the SubscriptionActivationModal when the checkbox is not checked.

A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

Local Testing

To see the button

  1. You should have a (legacy) license in your instance. You can refer to this for how to do that.

  2. Make sure you have set the following environment vars (usually in your terminal) and restart gdk

    • GITLAB_LICENSE_MODE is set to test
    • CUSTOMER_PORTAL_URL is set to https://customers.stg.gitlab.com
  3. Use Rails console to run ApplicationSetting.current.update(cloud_license_enabled: true)

  4. Visit Admin > Subscription

Screenshots (strongly suggested)

Before After
Screenshot_2021-06-29_at_14.32.17 Screenshot_2021-06-30_at_08.35.20

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #334863

Edited by Angelo Gulina

Merge request reports

Loading