Add locking to pipeline add job service
What does this MR do?
We saw some repeated requests in small frequencies, so we decided to add a lock mechanism to Ci::Pipelines::AddJobService
.
This MR adds an exclusive lock to the service based on the "ci:pipelines:#{pipeline.id}:add-job"
key because Ci::Pipeline
can be our reference when the requests try to add different jobs in small frequencies.
It's behind a feature flag ci_pipeline_add_job_with_lock
(#337628 (closed)).
Related to #326791 (closed)
Screenshots or Screencasts (strongly suggested)
Example;
Ci::Pipelines::AddJobService.new(pipeline).execute!(job) do |j|
puts Time.now
sleep 3
puts Time.now
end
First request;
Project Load (3.7ms) SELECT "projects".* FROM "projects" WHERE "projects"."id" = 20 LIMIT 1 /*application:console,line:/app/services/ci/pipelines/add_job_service.rb:46:in `assign_pipeline_attributes'*/
2021-08-04 14:37:30 +0300
2021-08-04 14:37:33 +0300
CommitStatus Update All (0.9ms) UPDATE "ci_builds" SET "retried" = TRUE, "processed" = TRUE WHERE "ci_builds"."commit_id" = 96 AND ("ci_builds"."retried" = FALSE OR "ci_builds"."retried" IS NULL) AND "ci_builds"."name" = 'deploy' AND "ci_builds"."id" != 816 /*application:console,line:/app/models/commit_status.rb:293:in `update_older_statuses_retried!'*/
Second request;
Project Load (3.4ms) SELECT "projects".* FROM "projects" WHERE "projects"."id" = 20 LIMIT 1 /*application:console,line:/app/services/ci/pipelines/add_job_service.rb:46:in `assign_pipeline_attributes'*/
2021-08-04 14:37:33 +0300
2021-08-04 14:37:36 +0300
CommitStatus Update All (0.8ms) UPDATE "ci_builds" SET "retried" = TRUE, "processed" = TRUE WHERE "ci_builds"."commit_id" = 96 AND ("ci_builds"."retried" = FALSE OR "ci_builds"."retried" IS NULL) AND "ci_builds"."name" = 'deploy' AND "ci_builds"."id" != 816 /*application:console,line:/app/models/commit_status.rb:293:in `update_older_statuses_retried!'*/
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Furkan Ayhan