Global Search - Track Top Nav Searches
What does this MR do?
Closes #336001 (closed)
Follow up from feature recently implemented: #239384 (closed)
We are currently tracking frequently searched Groups and Projects as part of our effort to enhance the Group and Project filters on the Global Search page.
Currently we store all usages of the Groups and Projects when interacted with on the Global Search page. This is done via localStorage
.
Along with this we also have found users often navigate to a Group/Project Page to utilize the scoped search feature on the Top Nav Search Bar. This behavior is due to a history of those filters not being very useful in the past. We have made many improvements to these filters in the most recent milestones and are working to rebuild the trust in those filters.
This change adds logic to additionally track frequent searched Groups and Projects when they are searched via the Top Nav. To do so we piggy back off the already implemented nav_source
parameter that is added when a user searches from there. This allows us to also track searches coming from there (and if ever needed any additional locations outside of the Global Search page)!
Screenshots or Screencasts (strongly suggested)
Video of usage
Top_nav_trackedHow to setup and validate locally (strongly suggested)
- Fetch local branch
- Navigate to a group/project
- Type in a search term via the
Search GitLab
search field at the top right of the screen - Either hit enter, click search in Project, or search in Group
- Once page navigates, open the respected Group/Project dropdown depending on what you did in step 4
- Ensure that Group/Project is now in your "Frequently searched" section
- For extensive testing you may want to clear your cache here is how:
How to clear your cache
Clear_LSDoes this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #336001 (closed)