Add unique constraint and model layer validation for vulnerability flag type
requested to merge add_unique_constraint_and_model_layer_validation_for_vulnerability_flag_type into master
What does this MR do?
This MR introduces a model layer validation and DB layer uniqueness constraint for the flag_type
, origin
, and vulnerability_occurrence_id
columns.
Database review
I didn't put any delete query before executing the create unique index
statement as the table is empty and we are currently not writing to this table. However, adding the delete statement to wipe the table out might make sense so I will defer this to the maintainer.
rake db:migrate:up VERSION=20210803110920
== 20210803110920 AddUniqueIndexToVulnerabilityFlagsTable: migrating ==========
-- transaction_open?()
-> 0.0000s
-- index_exists?(:vulnerability_flags, [:vulnerability_occurrence_id, :flag_type, :origin], {:name=>"index_vulnerability_flags_on_unique_columns", :unique=>true, :algorithm=>:concurrently})
-> 0.0034s
-- execute("SET statement_timeout TO 0")
-> 0.0005s
-- add_index(:vulnerability_flags, [:vulnerability_occurrence_id, :flag_type, :origin], {:name=>"index_vulnerability_flags_on_unique_columns", :unique=>true, :algorithm=>:concurrently})
-> 0.0035s
-- execute("RESET ALL")
-> 0.0005s
== 20210803110920 AddUniqueIndexToVulnerabilityFlagsTable: migrated (0.0097s) =
rake db:migrate:down VERSION=20210803110920
== 20210803110920 AddUniqueIndexToVulnerabilityFlagsTable: reverting ==========
-- transaction_open?()
-> 0.0000s
-- indexes(:vulnerability_flags)
-> 0.0029s
-- execute("SET statement_timeout TO 0")
-> 0.0005s
-- remove_index(:vulnerability_flags, {:algorithm=>:concurrently, :name=>"index_vulnerability_flags_on_unique_columns"})
-> 0.0031s
-- execute("RESET ALL")
-> 0.0005s
== 20210803110920 AddUniqueIndexToVulnerabilityFlagsTable: reverted (0.0090s) =
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. - [-] This change is backwards compatible across updates, or this does not apply.
Availability and Testing
- [-] I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
- [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mehmet Emin INAC