Skip to content

Add unique constraint and model layer validation for vulnerability flag type

What does this MR do?

This MR introduces a model layer validation and DB layer uniqueness constraint for the flag_type, origin, and vulnerability_occurrence_id columns.

Database review

I didn't put any delete query before executing the create unique index statement as the table is empty and we are currently not writing to this table. However, adding the delete statement to wipe the table out might make sense so I will defer this to the maintainer.

rake db:migrate:up VERSION=20210803110920

== 20210803110920 AddUniqueIndexToVulnerabilityFlagsTable: migrating ==========
-- transaction_open?()
   -> 0.0000s
-- index_exists?(:vulnerability_flags, [:vulnerability_occurrence_id, :flag_type, :origin], {:name=>"index_vulnerability_flags_on_unique_columns", :unique=>true, :algorithm=>:concurrently})
   -> 0.0034s
-- execute("SET statement_timeout TO 0")
   -> 0.0005s
-- add_index(:vulnerability_flags, [:vulnerability_occurrence_id, :flag_type, :origin], {:name=>"index_vulnerability_flags_on_unique_columns", :unique=>true, :algorithm=>:concurrently})
   -> 0.0035s
-- execute("RESET ALL")
   -> 0.0005s
== 20210803110920 AddUniqueIndexToVulnerabilityFlagsTable: migrated (0.0097s) =

rake db:migrate:down VERSION=20210803110920

== 20210803110920 AddUniqueIndexToVulnerabilityFlagsTable: reverting ==========
-- transaction_open?()
   -> 0.0000s
-- indexes(:vulnerability_flags)
   -> 0.0029s
-- execute("SET statement_timeout TO 0")
   -> 0.0005s
-- remove_index(:vulnerability_flags, {:algorithm=>:concurrently, :name=>"index_vulnerability_flags_on_unique_columns"})
   -> 0.0031s
-- execute("RESET ALL")
   -> 0.0005s
== 20210803110920 AddUniqueIndexToVulnerabilityFlagsTable: reverted (0.0090s) =

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mehmet Emin INAC

Merge request reports

Loading