Skip to content

Display correct nav block when viewing blob

Samantha Ming requested to merge 334790-navblock-display-correctly into master

What does this MR do?

When navigating from the repository files view, the incorrect nav block is displayed when viewing a blob. The dropdown should not be displayed. This MR removes the dropdown when viewing a blob.

Before This MR
image image

How to setup and validate locally (strongly suggested)

This feature is behind a feature flag, to turn on:

rails c

Feature.enable(:refactor_blob_viewer)
  1. Navigate to the Repository Files page
  2. Click on a blob file (non-folder item)
  • The dropdown is not displayed

no-dropdown-when-viewing-blob

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #334790 (closed)

Edited by Samantha Ming

Merge request reports

Loading