Fix: Code block input rule doesn’t save the code block language
What does this MR do?
This MR fixes a bug that didn’t store a code block language when inserting a code block using an Input Rule. The solution for this problem is rewriting the Markdown Serializer for code blocks to use a language attribute instead of a params attribute.
The code block extension sets the language attribute by default when inserting a code block using an input rule.
Screenshots or Screencasts (strongly suggested)
| Inserting a code block | Viewing the code block |
|---|---|
 |
 |
How to setup and validate locally (strongly suggested)
- Edit a Wiki page in your local environment
- Choose the Content Editor as your editor of choice
- Insert a code block typing the following keys: ```javascript(space)
- The Content Editor will create a code block that highlights javascript code.
- Submit changes
- When viewing the Wiki page, the code block should still highlight JavaScript code.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team