Skip to content

Fix: Code block input rule doesn’t save the code block language

Enrique Alcántara requested to merge fix-code-block-input-rule into master

What does this MR do?

This MR fixes a bug that didn’t store a code block language when inserting a code block using an Input Rule. The solution for this problem is rewriting the Markdown Serializer for code blocks to use a language attribute instead of a params attribute.

The code block extension sets the language attribute by default when inserting a code block using an input rule.

Screenshots or Screencasts (strongly suggested)

Inserting a code block Viewing the code block
content-editor-code-block viewing_code_block_in_Wiki

How to setup and validate locally (strongly suggested)

  • Edit a Wiki page in your local environment
  • Choose the Content Editor as your editor of choice
  • Insert a code block typing the following keys: ```javascript(space)
  • The Content Editor will create a code block that highlights javascript code.
  • Submit changes
  • When viewing the Wiki page, the code block should still highlight JavaScript code.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading