Skip to content

Hide None and Any when filtered token is !=

Coung Ngo requested to merge cngo-hide-none-any-when-not-equal into master

What does this MR do?

This MR hides the None and Any filtered search suggestions in the Vue implementation when the chosen operator is !=, to match the existing Haml logic. != None and != Any are not necessary anyway because != None == Any and != Any == None.

This MR also replaces the DEFAULT_LABELS constant with DEFAULT_NONE_ANY to remove the duplication

See: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/filtered_search/filtered_search_dropdown.js#L150

This is tested in https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/features/issues/filtered_search/visual_tokens_spec.rb#L180

Screenshots or Screencasts (strongly suggested)

Screen_Recording_2021-08-17_at_1.11.14_pm

How to setup and validate locally (strongly suggested)

  1. In rails console enable the vue_issues_list feature flag
    Feature.enable(:vue_issues_list)
  2. Visit a project issues page and use the filtered search bar (e.g. http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports

Loading