Hide None and Any when filtered token is !=
What does this MR do?
This MR hides the None
and Any
filtered search suggestions in the Vue implementation
when the chosen operator is !=, to match the existing
Haml logic. != None
and != Any
are not necessary anyway because != None
== Any
and != Any
== None
.
This MR also replaces the DEFAULT_LABELS
constant with DEFAULT_NONE_ANY
to remove the duplication
This is tested in https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/features/issues/filtered_search/visual_tokens_spec.rb#L180
Screenshots or Screencasts (strongly suggested)
Screen_Recording_2021-08-17_at_1.11.14_pm
How to setup and validate locally (strongly suggested)
- In rails console enable the
vue_issues_list
feature flagFeature.enable(:vue_issues_list)
- Visit a project issues page and use the filtered search bar (e.g. http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo