Add support for non-cilium network policies
What does this MR do?
Add support for non-cilium network policies
- I originally removed this feature because the feature was listed as deprecated
- now they want it back
- update tests
- update mocks to be more organized
How to setup and validate locally (strongly suggested)
- Follow the Protect Onboarding task to be able to create network policies in kubernetes/cilium
- Follow the scan execution creation snippet to create some scan execution policies
- Turn on the
:security_policies_orchestration_configurationfeature flag - Navigate to
Security & Compliance=>Policies - Change the security policy project
Screenshots or Screencasts (strongly suggested)
| Page | Screenshot |
|---|---|
| Edit page - non-cilium policy |  |
| Edit page - cilium policy |  |
| Drawer - non-cilium policy |  |
| Drawer - cilium policy |  |
| Drawer - scan execution policy |  |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #338521 (closed)