Skip to content

Split "comment type" dropdown into a new component

Mike Greiling requested to merge mg-separate-comment-type-dropdown-logic into master

What does this MR do?

This MR splits the "comment type" dropdown into its own separate component which can be re-used on the Snippets and Commit page discussion implementations (part of #241800 (closed))

Screenshots or Screencasts (strongly suggested)

CleanShot_2021-08-18_at_18.21.57_2x

How to setup and validate locally (strongly suggested)

Example below:

  1. Check out this branch locally
  2. Visit a merge request, issue, or epic
  3. Type some text into the comment form
  4. Validate that the dropdown to select "Comment" or "Start thread" works properly.
    • It opens and resembles the screenshot above
    • Clicking either option changes the button text
    • Clicking the button performs the desired action

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

This change poses little risk, it is mostly shuffling things around. No new feature is added or removed and if it works as it should there should be no changes to the user experience whatsoever.

Tests have been added and updated where appropriate.

Edited by Mike Greiling

Merge request reports

Loading