Fix yaml viewer padding not changing color
What does this MR do?
Fix yaml viewer padding not changing color
- a user can update the color preferences of the text editor
- the yaml viewer/editor was not updating colors appropriately because of some CSS hacking
- with the newer version of monaco, we can remove the CSS hacks and properly fix the padding
Screenshots or Screencasts (strongly suggested)
Page | Before | After |
---|---|---|
Policy Drawer | ||
Policy Editor - Rule Mode | No visual change | |
Policy Editor - YAML mode |
How to setup and validate locally (strongly suggested)
- Upload a GitLab Ultimate license
- Follow the Protect Onboarding task to be able to create network policies in kubernetes/cilium
- Navigate to
Security & Compliance
=>Threat Monitoring
=>Policies
tab - Click
New policy
- Inspect the editor
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #332073 (closed)
Edited by Alexander Turinske