Skip to content

Rescue PGQuery::ParseError in prevent_cross_joins

Dylan Griffith requested to merge 346755-catch-parse-errors-cross-joins into master

What does this MR do and why?

This query subscriber is used to detect "cross-joins" that will not work when CI tables are moved to a separate database.

These ParseError can happen for some valid Postgres queries due to an issue with the library handling large nested queries. As such it's safest to just ignore any queries that fail to parse.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #346755 (closed)

Merge request reports