ci: Remove `needs` from the `review-qa-*-report` jobs
What does this MR do and why?
It looks like the rule for the report jobs are different based on the QA job allow_failure
attribute:
- If the QA job has
allow_failure: true
- If the QA job has
when: on_success
, then the report job can havewhen: on_success
andwhen: on_failure
, or justwhen: always
- If the QA job has
when: manual
, then the report job needs to havewhen: on_success
andwhen: on_failure
- If the QA job has
- If the QA job doesn't have
allow_failure: true
, then the report job needs to havewhen: always
See the tables below for details about these findings.
on_success
and not allowed to fail (e.g. report-qa-smoke
)
QA job that run Report job when
|
Report job runs when QA job fails? |
---|---|
on_success /on_failure not allowed to fail |
No |
on_success /on_failure allowed to fail |
No |
always not allowed to fail |
Yes |
always allowed to fail |
Yes |
Example pipeline: https://gitlab.com/rymai/test-project/-/pipelines/430243852
manual
and allowed to fail (e.g. report-qa-all
)
QA job that run Report job when
|
Report job runs when QA job isn't run? | Report job runs when QA job fails? |
---|---|---|
on_success /on_failure not allowed to fail |
No | Yes |
on_success /on_failure allowed to fail |
No | Yes |
always not allowed to fail |
Yes | Already ran |
always allowed to fail |
Yes | Already ran |
Example pipeline: https://gitlab.com/rymai/test-project/-/pipelines/430243852
on_success
and allowed to fail
QA job that run Report job when
|
Report job runs when QA job fails? |
---|---|
on_success /on_failure not allowed to fail |
Yes |
on_success /on_failure allowed to fail |
Yes |
always not allowed to fail |
Yes |
always allowed to fail |
Yes |
Example pipeline: https://gitlab.com/rymai/test-project/-/pipelines/430246947
manual
and not allowed to fail
QA job that run Report job when
|
Report job runs when QA job isn't run? | Report job runs when QA job fails? |
---|---|---|
on_success /on_failure not allowed to fail |
No (pipeline is blocked) | No |
on_success /on_failure allowed to fail |
No (pipeline is blocked) | No |
always not allowed to fail |
No (pipeline is blocked) | Yes |
always allowed to fail |
No (pipeline is blocked) | Yes |
Example pipeline: https://gitlab.com/rymai/test-project/-/pipelines/430246947
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Rémy Coutable