Skip to content

ci: Remove `needs` from the `review-qa-*-report` jobs

Rémy Coutable requested to merge fix-review-qa-smoke-report into master

What does this MR do and why?

It looks like the rule for the report jobs are different based on the QA job allow_failure attribute:

  • If the QA job has allow_failure: true
    • If the QA job has when: on_success, then the report job can have when: on_success and when: on_failure, or just when: always
    • If the QA job has when: manual, then the report job needs to have when: on_success and when: on_failure
  • If the QA job doesn't have allow_failure: true, then the report job needs to have when: always

See the tables below for details about these findings.

QA job that run on_success and not allowed to fail (e.g. report-qa-smoke)

Report job when Report job runs when QA job fails?
on_success/on_failure not allowed to fail No
on_success/on_failure allowed to fail No
always not allowed to fail Yes
always allowed to fail Yes

Example pipeline: https://gitlab.com/rymai/test-project/-/pipelines/430243852

QA job that run manual and allowed to fail (e.g. report-qa-all)

Report job when Report job runs when QA job isn't run? Report job runs when QA job fails?
on_success/on_failure not allowed to fail No Yes
on_success/on_failure allowed to fail No Yes
always not allowed to fail Yes Already ran
always allowed to fail Yes Already ran

Example pipeline: https://gitlab.com/rymai/test-project/-/pipelines/430243852

QA job that run on_success and allowed to fail

Report job when Report job runs when QA job fails?
on_success/on_failure not allowed to fail Yes
on_success/on_failure allowed to fail Yes
always not allowed to fail Yes
always allowed to fail Yes

Example pipeline: https://gitlab.com/rymai/test-project/-/pipelines/430246947

QA job that run manual and not allowed to fail

Report job when Report job runs when QA job isn't run? Report job runs when QA job fails?
on_success/on_failure not allowed to fail No (pipeline is blocked) No
on_success/on_failure allowed to fail No (pipeline is blocked) No
always not allowed to fail No (pipeline is blocked) Yes
always allowed to fail No (pipeline is blocked) Yes

Example pipeline: https://gitlab.com/rymai/test-project/-/pipelines/430246947

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rémy Coutable

Merge request reports