Skip to content

Global Search Refactor - Fix Focus Contrast

Zack Cuddy requested to merge 345745_05-better-focus-contrast into master

What does this MR do and why?

This addresses a regression found in here: !74244 (comment 731485313)
Work towards #297396 (closed)

This change is behind a feature flag (:new_header_search)
Feature Flag Rollout Issue: #339348 (closed)

This change fixes the contrast issues when focusing the new Header Search.

Screenshots or screen recordings

Before After
Light Mode Light_Mode_-_Before Light_Mode_-_After
Dark Mode Dark_Mode_-_Before Dark_Mode

How to set up and validate locally

  1. Fetch and checkout this branch
  2. Activate the Feature Flag
  3. Set Theme to a Light Mode theme (any but Dark Mode)
  4. Focus the Header Search
  5. Ensure placeholder and typed text has a good contrast
  6. Set Theme to Dark Mode theme
  7. Focus the Header Search
  8. Ensure placeholder and typed text has a good contrast

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zack Cuddy

Merge request reports

Loading