Global Search Refactor - Fix Focus Contrast
What does this MR do and why?
This addresses a regression found in here: !74244 (comment 731485313)
Work towards #297396 (closed)
This change is behind a feature flag (:new_header_search
)
Feature Flag Rollout Issue: #339348 (closed)
This change fixes the contrast issues when focusing the new Header Search.
Screenshots or screen recordings
Before | After | |
---|---|---|
Light Mode | ||
Dark Mode |
How to set up and validate locally
- Fetch and checkout this branch
- Activate the Feature Flag
- Set Theme to a Light Mode theme (any but Dark Mode)
- Focus the Header Search
- Ensure placeholder and typed text has a good contrast
- Set Theme to Dark Mode theme
- Focus the Header Search
- Ensure placeholder and typed text has a good contrast
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Zack Cuddy