Resolve "Replace `data-confirm` modals with `GlModal` in `app/views/admin/labels/_label.html.haml`"
requested to merge 344181-replace-data-confirm-modals-with-glmodal-in-app-views-admin-labels-_label-html-haml into master
What does this MR do and why?
Update the confirmation button variant to danger
and its label to Delete
on delete label confirmation modal.
Screenshots or screen recordings
Without FF | With FF (before) | With FF (after) |
---|---|---|
How to set up and validate locally
- Enable the
bootstrap_confirmation_modals
feature flag:Feature.enable(:bootstrap_confirmation_modals)
- Login as admin
- Go to http://localhost:3000/admin/labels
- If there isn't a label, create one by clicking
New label
- Click
Delete
next to one of the labels on the list
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #344181 (closed)
Edited by Vamsi Vempati