Skip to content

Resolve "Replace `data-confirm` modals with `GlModal` in `app/views/admin/labels/_label.html.haml`"

What does this MR do and why?

Update the confirmation button variant to danger and its label to Delete on delete label confirmation modal.

Screenshots or screen recordings

Without FF With FF (before) With FF (after)
Screen_Shot_2022-02-08_at_12.31.07_PM Screen_Shot_2022-02-08_at_12.24.23_PM Screen_Shot_2022-02-09_at_11.33.48_AM

How to set up and validate locally

  1. Enable the bootstrap_confirmation_modals feature flag: Feature.enable(:bootstrap_confirmation_modals)
  2. Login as admin
  3. Go to http://localhost:3000/admin/labels
  4. If there isn't a label, create one by clicking New label
  5. Click Delete next to one of the labels on the list

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344181 (closed)

Edited by Vamsi Vempati

Merge request reports

Loading