Skip to content

Revert "Merge branch '230764-mlunoe-migrate-groups-sso-tabs-to-gl-tabs' into 'master'"

Catalin Irimie requested to merge revert-3e3af288 into master

What does this MR do and why?

Reverts !82512 (merged) as it seems be causing gitlab-com/gl-infra/production#6567 (closed) with:

Uncaught Error: Cannot instantiate GlTabsBehavior without an element
    GlTabsBehavior index.js:95
    <anonymous> index.js:6
    sJE6 pages.groups.sso.chunk.js:85
    __webpack_require__ runtime.bundle.js:85
    324 pages.groups.sso.chunk.js:12
    __webpack_require__ runtime.bundle.js:85
    checkDeferredModules runtime.bundle.js:46
    webpackJsonpCallback runtime.bundle.js:33
    <anonymous> pages.groups.sso.chunk.js:1
index.js:95

Screenshots or screen recordings

How to set up and validate locally

  1. With GDK + SAML enabled, go to the SAML group SSO link (https://gdk.test:3443/groups/cat-saml/-/saml/sso?token=49RFqtBK as an example)
  2. Login, then go to the same link again and notice the broken redirect
  3. Checkout this branch, try the login again and see it redirecting

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports