Draft: Refactor compliance framework pills to display as badges
What does this MR do and why?
This MR updates the compliance framework pills to render as badges instead of labels.
Why? Because GlLabel
expects an action (href
) and there is none for compliance framework pills.
This also brings the Vue component inline with the HAML partial compliance_framework_badge
.
Screenshots or screen recordings
Group item
Before | After |
---|---|
Compliance report sidebar (also shows hover state)
Before | After |
---|---|
How to set up and validate locally
- You need a GitLab Ultimate license.
- View the group settings at
http://gdk.test:3000/groups/gitlab-org/-/edit#js-compliance-frameworks-settings
. - Add a label with a scope, for example
GDPR::UK
. - Apply the label to a project in the group at
http://gdk.test:3000/gitlab-org/gitlab-shell/edit
. - Verify the group item pill at
http://gdk.test:3000/gitlab-org
. - Verify the compliance report sidebar pill at
http://gdk.test:3000/groups/gitlab-org/-/security/compliance_dashboard
.- If no violations are visible update the start date to a few months back.
- Filter for the project you applied the compliance framework to:
gitlab-shell
. - Click on a violation row to open the sidebar.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #325260 (closed)
Edited by Jiaan Louw