(Part 5) FE multiple approval rules - mr edit
requested to merge 1979-fe-part5-approvals-mr-components into 1979-fe-part4-approvals-shared-components
What does this MR do?
This MR implements the approval rules section of the MR edit form.
Please note! This is part of a larger MR. You can see the full functionality here https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9168
Instructions!
- Please note that this does not point to
master
. - Once https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9176 is merged, then rebase and point this MR to the feature branch
1979-fe-multiple-approval-rules
.
TODO
-
Unit tests -
Verify this doesn't fail any rspecs (other than the ones already failing in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8769)
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer
Edited by Paul Slaughter