Skip to content

Geo Replicables - Enhanced Empty States

Zack Cuddy requested to merge 369581-better-geo-empty-states into master

What does this MR do and why?

Closes #369581 (closed)

This change overhauls our empty states when viewing Geo Replicables. The key changes are:

  1. Remove verbiage mentioning filters and searching when they aren't being used.
  2. Align the filtered/searched empty state with: https://design.gitlab.com/regions/empty-states/#empty-search-results

Important Context

There are 3 different views that are responsible for rendering the Geo Replicables. If you are curious, here is a link to the breakdown of technical approaches and reasoning: &8212 (closed)

What you need to know for this MR is:

  1. Projects are rendered via HAML/Ruby and have full filtering capabilities.
  2. Designs are rendered via Vue/REST and have full filtering capabilities.
  3. Everything else is rendered via Vue/GraphQL and have NO filtering capabilities.

Screenshots or screen recordings

Empty States without Filters

Before After
Projects (HAML/Ruby) Projects_No_Filter_-_Before Projects_No_Filter_-_After
Designs (Vue/REST) Designs_No_Filters_-_Before Designs_No_Filters_-_After
Everything else (Vue/GraphQL) SSF_No_Filters_-_Before SSF_No_Filters-_After

Empty States with Filters

Before After
Projects (HAML/Ruby) Projects_Filter_-_Before Projects_Filter_-_After
Designs (Vue/REST) Designs_Filters_-_Before Designs_Filters_-_After
Everything else (Vue/GraphQL) N/A N/A

How to set up and validate locally

  1. Setup Geo and access your Secondary GDK (How to setup Geo).
  2. Fetch and checkout this branch on both GDKs.
  3. Navigate to the Geo Replicables Projects Tab (http://127.0.0.1:3001/admin/geo/replication/projects)
  4. Add filters and ensure empty state is correct
  5. Click the Designs Tab
  6. Add filters and ensure the empty state is correct
  7. Go to an empty tab (ex. Merge Request Diffs)
  8. Ensure the empty state is correct

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #369581 (closed)

Edited by Zack Cuddy

Merge request reports

Loading