Geo Replicables - Enhanced Empty States
What does this MR do and why?
Closes #369581 (closed)
This change overhauls our empty states when viewing Geo Replicables. The key changes are:
- Remove verbiage mentioning filters and searching when they aren't being used.
- Align the filtered/searched empty state with: https://design.gitlab.com/regions/empty-states/#empty-search-results
Important Context
There are 3 different views that are responsible for rendering the Geo Replicables. If you are curious, here is a link to the breakdown of technical approaches and reasoning: &8212 (closed)
What you need to know for this MR is:
- Projects are rendered via HAML/Ruby and have full filtering capabilities.
- Designs are rendered via Vue/REST and have full filtering capabilities.
- Everything else is rendered via Vue/GraphQL and have NO filtering capabilities.
Screenshots or screen recordings
Empty States without Filters
Before | After | |
---|---|---|
Projects (HAML/Ruby) | ||
Designs (Vue/REST) | ||
Everything else (Vue/GraphQL) |
Empty States with Filters
Before | After | |
---|---|---|
Projects (HAML/Ruby) | ||
Designs (Vue/REST) | ||
Everything else (Vue/GraphQL) | N/A | N/A |
How to set up and validate locally
- Setup Geo and access your Secondary GDK (How to setup Geo).
- Fetch and checkout this branch on both GDKs.
- Navigate to the Geo Replicables Projects Tab (
http://127.0.0.1:3001/admin/geo/replication/projects
) - Add filters and ensure empty state is correct
- Click the Designs Tab
- Add filters and ensure the empty state is correct
- Go to an empty tab (ex. Merge Request Diffs)
- Ensure the empty state is correct
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #369581 (closed)
Edited by Zack Cuddy