Skip to content

Hide billable users row in Admin Area > Users Statistics on EE when no license is present

Luke Stahlman requested to merge show-billable-row-stat-only-when-license-exists into master

What does this MR do and why?

This fixes an issue where the Admin Area > Users Statistics page displays a billable user count on unlicensed EE instances. This has led to some confusion in discussions with prospective customers.

Screenshots or screen recordings

Before After
Billable_displayed Billable_hidden

How to set up and validate locally

This MR includes a new spec for the statistics page to validate Billable Users is only displayed when a license exists on the instance. See manual steps below.

Reproduce issue

  1. Create a GitLab EE instance without this MR, do not apply a license
  2. As an administrator, navigate to <instance url>/admin/dashboard/stats
  3. Verify a Billable Users row exists in the statistics table

Validate fix

  1. Create a GitLab EE instance with this MR, do not apply a license
  2. As an administrator, navigate to <instance url>/admin/dashboard/stats
  3. Verify the Billable Users row does not exist in the statistics table
  4. Apply a license to the instance
  5. Return to <instance url>/admin/dashboard/stats
  6. Verify a Billable Users row exists in the statistics table

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Luke Stahlman

Merge request reports