Hide billable users row in Admin Area > Users Statistics on EE when no license is present
What does this MR do and why?
This fixes an issue where the Admin Area > Users Statistics
page displays a billable user count on unlicensed EE instances. This has led to some confusion in discussions with prospective customers.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
This MR includes a new spec for the statistics page to validate Billable Users
is only displayed when a license exists on the instance. See manual steps below.
Reproduce issue
- Create a GitLab EE instance without this MR, do not apply a license
- As an administrator, navigate to
<instance url>/admin/dashboard/stats
- Verify a
Billable Users
row exists in the statistics table
Validate fix
- Create a GitLab EE instance with this MR, do not apply a license
- As an administrator, navigate to
<instance url>/admin/dashboard/stats
- Verify the
Billable Users
row does not exist in the statistics table - Apply a license to the instance
- Return to
<instance url>/admin/dashboard/stats
- Verify a
Billable Users
row exists in the statistics table
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Luke Stahlman