Skip to content

Resolve "Add favicons"

Hiru Fernando requested to merge 140-add-favicons into main

What does this MR do and why?

This MR adds extra favicon assets to support things like apple shortcut icon, etc. The implementation follows the setup mentioned here: https://frontendmasters.com/blog/how-to-favicon-in-2024/

Screenshots, screen recordings, or links to review app

CHROME SAFARI FIREFOX
image image image

No new console errors:

CHROME SAFARI FIREFOX
image image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/technical-writing-group/gitlab-docs-hugo/-/blob/main/doc/setup.md.
  2. Check favicon still shows up. I believe apple-touch-icon can be tested once we have preview url / this gets merged and we check it in new.docs.gitlab.com site on our phone.

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #140 (closed)

Edited by Hiru Fernando

Merge request reports

Loading