Implement token selector component for group "Restrict membership by email" field
requested to merge 220567-implement-token-selector-component-for-group-restrict-membership-by-email-field into master
What does this MR do?
See #220567 (closed)
Improves the UI/UX of group Allowed domain restriction field by switching from a comma separated list to the GitLab UI Token Selector component
Note: The focused token color (press delete to focus on a token) will be too light until #224118 (closed) has been implemented.
Screenshots
Before | After |
---|---|
Local Testing
- Install a GitLab Silver License
- Create a new group
- Navigate to your group -> "Settings" -> "General" -> "Permissions, LFS, 2FA"
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Jang