Skip to content

Implement token selector component for group "Restrict membership by email" field

What does this MR do?

See #220567 (closed)

Improves the UI/UX of group Allowed domain restriction field by switching from a comma separated list to the GitLab UI Token Selector component

Note: The focused token color (press delete to focus on a token) will be too light until #224118 (closed) has been implemented.

Screenshots

Before After
Screen_Shot_2020-06-29_at_10.23.38_AM Screen_Shot_2020-06-29_at_10.20.09_AM

Local Testing

  1. Install a GitLab Silver License
  2. Create a new group
  3. Navigate to your group -> "Settings" -> "General" -> "Permissions, LFS, 2FA"

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Jang

Merge request reports

Loading