Skip to content

Fix error on vulnerability list when there are no vulnerabilities

Daniel Tian requested to merge 280521-fix-no-vulnerability-errors into master

What does this MR do?

On the security dashboard, there is a vulnerability list:

ksnip_20201109-115051

This MR fixes the following issues when there are no vulnerabilities:

  1. When viewing the project-level security dashboard, there is an error. This has been fixed to show the "No vulnerabilities found" message.
Before After
Screenshot_from_2020-11-08_21-58-56 Screenshot_from_2020-11-09_11-53-00
  1. The "Sorry, your filter produced no results" error message does not have the SVG image. It has been added back in:
Before After
Screenshot_from_2020-11-08_23-39-46 Screenshot_from_2020-11-08_23-41-09
  1. The "Sorry, your filter produced no results" message is shown when there are no vulnerabilities to begin with. It now shows the "No vulnerabilities found" message:
Before After
Screenshot_from_2020-11-08_23-41-09 Screenshot_from_2020-11-09_11-53-00
  1. The "Report not configured" message was never shown due to a bug. This has been fixed:
Before After
Screenshot_from_2020-11-09_11-53-00 Screenshot_from_2020-11-09_11-57-44

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #280521 (closed)

Edited by Daniel Tian

Merge request reports

Loading