Fix error on vulnerability list when there are no vulnerabilities
What does this MR do?
On the security dashboard, there is a vulnerability list:
This MR fixes the following issues when there are no vulnerabilities:
- When viewing the project-level security dashboard, there is an error. This has been fixed to show the "No vulnerabilities found" message.
Before | After |
---|---|
- The "Sorry, your filter produced no results" error message does not have the SVG image. It has been added back in:
Before | After |
---|---|
- The "Sorry, your filter produced no results" message is shown when there are no vulnerabilities to begin with. It now shows the "No vulnerabilities found" message:
Before | After |
---|---|
- The "Report not configured" message was never shown due to a bug. This has been fixed:
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #280521 (closed)
Edited by Daniel Tian