Skip to content

For consistency do not use CSS calc for simple calculation of margin-top

What does this MR do?

This MR changes the way the margin-top is calculated for the "What's new" sidebar when there is the "Performance bar" visible.

As discussed in MR !66660 (merged) there was a possible and desired but unrelated change to not use CSS calc. To not mix unrelated changes, this was split out into it's own MR.

  margin-top: calc(#{$performance-bar-height} + #{$header-height});

Screenshots or Screencasts (strongly suggested)

Verified locally

Screen_Shot_2021-08-03_at_12.14.38_PM

How to setup and validate locally (strongly suggested)

--

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Paul Slaughter

Merge request reports

Loading